Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not show edit action for version objects where editing is not possible #405

Merged
merged 4 commits into from
May 3, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 2, 2024

Description

Fixes #404 , where the edit action is shown for an unpublished version.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb May 2, 2024 19:05
@fsbraun fsbraun requested a review from a team May 3, 2024 08:40
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fsbraun fsbraun merged commit 4c80aa5 into master May 3, 2024
109 checks passed
@fsbraun fsbraun deleted the fix/edit-action branch October 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unpublished version shows edit action
2 participants