Skip to content

feat: Add versioning actions to settings (admin change view) of versioned objects #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 5, 2024

Description

This PR adds standard versioning actions to the change of view of versioned objects, including page contents:

image

This includes a "New Draft" button for published versions:

image

Further improvements:

  • "Versions" button takes the user to the version list.
  • The version list includes a new settings action for frontend-editable versioned objects to be able to see the settings historic objects (such as meta tags for unpublished versions)
image

(For not frontend-editable objects, the "View" button already takes the user to the change view and no settings button is offered.)

Finally, this PR fixes a bug that prevented users from editing slugs in some cases. (django-cms/django-cms#7866)

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Sorry, something went wrong.

fsbraun added 4 commits May 6, 2024 00:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@fsbraun fsbraun marked this pull request as ready for review May 14, 2024 22:13
@fsbraun fsbraun requested review from a team and mj8arrett May 14, 2024 22:13
fsbraun added 2 commits May 15, 2024 00:18
fsbraun added 3 commits May 22, 2024 17:07
@fsbraun fsbraun merged commit 34577f0 into master May 23, 2024
109 checks passed
@fsbraun fsbraun deleted the feat/admin-versioning-actions branch May 23, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants