Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Autocomplete fields for grouper selection and option for less verbose UI #433

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Nov 6, 2024

Description

  1. This PR adds autocomplete fields and some minimal styling to the grouper form when accessing the version change list:
    image
    Before this was a classical select drop-down which quickly gets difficult to handle with a growing number of pages or other grouper objects.

  2. Option for less verbose UI: Setting DJANGOCMS_VERSIONING_VERBOSE_UI ? False will remove the version change lists from the admin index view (to not clutter it). Version management is still accessible through the versioned models' admins. Also, it will make the version change list less wide by removing the created by date for easier access to the action buttons:
    image

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as draft November 6, 2024 12:42
@fsbraun fsbraun force-pushed the fix/grouper-selection branch from c991d78 to 7624763 Compare November 6, 2024 13:12
@fsbraun fsbraun marked this pull request as ready for review November 6, 2024 13:58
@fsbraun fsbraun requested a review from jrief November 6, 2024 13:59
@fsbraun fsbraun requested a review from a team January 13, 2025 15:23
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (3b3fa2f) to head (705dc71).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
djangocms_versioning/forms.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   91.16%   91.09%   -0.07%     
==========================================
  Files          72       72              
  Lines        2670     2685      +15     
  Branches      308      310       +2     
==========================================
+ Hits         2434     2446      +12     
- Misses        164      167       +3     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@fsbraun fsbraun merged commit 81306a0 into master Jan 15, 2025
97 of 99 checks passed
@fsbraun fsbraun deleted the fix/grouper-selection branch January 15, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants