-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Autocomplete fields for grouper selection and option for less verbose UI #433
Conversation
c991d78
to
7624763
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 91.16% 91.09% -0.07%
==========================================
Files 72 72
Lines 2670 2685 +15
Branches 308 310 +2
==========================================
+ Hits 2434 2446 +12
- Misses 164 167 +3
Partials 72 72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get this merged and released 🚢 🚀
Description
This PR adds autocomplete fields and some minimal styling to the grouper form when accessing the version change list:

Before this was a classical select drop-down which quickly gets difficult to handle with a growing number of pages or other grouper objects.
Option for less verbose UI: Setting

DJANGOCMS_VERSIONING_VERBOSE_UI ? False
will remove the version change lists from the admin index view (to not clutter it). Version management is still accessible through the versioned models' admins. Also, it will make the version change list less wide by removing the created by date for easier access to the action buttons:Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.