Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test.pypi.org workflow environment name #434

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix: test.pypi.org workflow environment name #434

merged 3 commits into from
Nov 7, 2024

Conversation

marksweb
Copy link
Member

@marksweb marksweb commented Nov 7, 2024

Description

Just noticed the environment name didn't match the standard setup for our pypi.org vs test.pypi.org publishing.

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun
fsbraun approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I updated the ubuntu version to latest to let tests pass.

@marksweb marksweb merged commit b191415 into master Nov 7, 2024
97 checks passed
@fsbraun fsbraun deleted the fix/ci-test-pypi branch November 7, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marksweb @fsbraun