Skip to content

Restore compatibility with iptools.IpRangeList #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2024
Merged

Restore compatibility with iptools.IpRangeList #1929

merged 1 commit into from
Jun 1, 2024

Conversation

quinox
Copy link
Contributor

@quinox quinox commented May 30, 2024

Description

As per the discussion in #1928.

Fixes #1928

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@quinox quinox mentioned this pull request May 30, 2024
Closed
matthiask
matthiask approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good approach. Checking __contains__ before resolving the IP should also alleviate the problem of slowness there for most uses.

@matthiask matthiask merged commit cf0cc0d into django-commons:main Jun 1, 2024
This was referenced Jul 30, 2024
Closed
Merged
johnthagen referenced this pull request Jul 30, 2024
@tim-schilling
Show toolbar for docker's internal IP address (#1887)
7d77a34 
Fixes #1854
@johnthagen johnthagen mentioned this pull request Jul 31, 2024
Closed
@matthiask matthiask mentioned this pull request Mar 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiask matthiask matthiask approved these changes

@tim-schilling tim-schilling tim-schilling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I can no longer use iptools.IpRangeList for INTERNAL_IPS
3 participants
@quinox @matthiask @tim-schilling