Support select and explain for UNION queries #1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UNION queries can start with "(", causing it to not be
classified as a SELECT query, and consequently the select and
explain buttons are missing on the SQL panel.
tests/panels/test_sql.py
Outdated
| @@ -729,6 +729,16 @@ def test_similar_and_duplicate_grouping(self): | |||
| self.assertNotEqual(queries[0]["similar_color"], queries[3]["similar_color"]) | |||
| self.assertNotEqual(queries[0]["duplicate_color"], queries[3]["similar_color"]) | |||
|
|
|||
| @unittest.skipUnless( | |||
| connection.vendor == "postgresql", "Test valid only on PostgreSQL" | |||
There was a problem hiding this comment.
How come this is only valid for postgres? I feel like the other db drivers should also pass this test.
There was a problem hiding this comment.
From a quick look at the Django code, this can only happen if the DB backend has supports_slicing_ordering_in_compound = True. But I see now it is more widely supported than I thought. Shall I rather use
@unittest.skipUnless(connection.vendor != "sqlite", "...")?
There was a problem hiding this comment.
I'm not sure why the skipUnless is even necessary? The test should pass on all database engines anyway, or not?
|
Thank you @friedelwolff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UNION queries can start with "(", causing it to not be classified as a SELECT query, and consequently the select and explain buttons are missing on the SQL panel.