add support for LoginRequiredMiddleware with login_not_required decor… #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiask
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Thanks for working on this!
Here's an example of an app adding support for login_not_required while actually testing the behavior:
feincms/django-authlib@2239a1c
I contributed same support for Django OAuth Toolkit in django-oauth/django-oauth-toolkit#1454. Thanks for the reference. |
dulmandakh
force-pushed
the
login_not_required
branch
from
513b764 to
d22d0ac
Compare
|
@matthiask please review and merge if this PR looks good |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for LoginRequiredMiddleware introduced in Django 5.1, or views provided by this package don't require login.
Checklist:
docs/changes.rst.