Skip to content

Commit 7b8e38e

Browse files
santiavenda2mblayman
authored andcommitted
Fix factory boy dependency (#373)
* Fix factory boy dependency * fix factory-boy version in setup.py and requirements-development.txt * Fix setup.py factory boy dependency * Add an explanation about factory_boy version pinning Include a link to the GitHub issue so a future dev will know when the dependency can be unpinned.
1 parent 2d691f4 commit 7b8e38e

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

requirements-development.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@ isort
55
mock
66
pytest>=2.9.0,<3.0
77
pytest-django
8+
# factory_boy is currently broken at 2.9 and above. See: https://github.com/pytest-dev/pytest-factoryboy/issues/47
9+
factory-boy<2.9.0
810
pytest-factoryboy
911
recommonmark
1012
Sphinx
1113
sphinx_rtd_theme
1214
tox
1315
mock
1416
django-debug-toolbar
15-
packaging==16.8
17+
packaging==16.8

setup.py

+1
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ def get_package_data(package):
105105
setup_requires=pytest_runner + sphinx + wheel,
106106
tests_require=[
107107
'pytest-factoryboy',
108+
'factory-boy<2.9.0',
108109
'pytest-django',
109110
'pytest>=2.8,<3',
110111
'django-polymorphic',

0 commit comments

Comments
 (0)