Fix factory boy dependency #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
+ Coverage 93% 93.05% +0.05%
===========================================
Files 51 51
Lines 2659 2665 +6
===========================================
+ Hits 2473 2480 +7
+ Misses 186 185 -1
Continue to review full report at Codecov.
|
|
Thanks @santiavenda2. Would you mind adding a comment with a link to the factory boy issue to the code and/or requirements.txt file so that future developers will be able to know when that dependency limitation can be removed in the future? |
Include a link to the GitHub issue so a future dev will know when the dependency can be unpinned.
|
Nevermind. I took care of adding the comment. Thanks for the fix! 👍 |
|
Thanks @mblayman 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factoy Boy 2.9.+ versions are raising this problem when we run the test suite using py.test
ConftestImportFailure: (local('/home/santiago/develop/invgate-django-rest-framework-json-api/example/tests/conftest.py'), (<type 'exceptions.AttributeError'>, AttributeError("'DjangoOptions' object has no attribute 'postgen_declarations'",), <traceback object at 0x7fb1c6b123b0>))
Related issue pytest-dev/pytest-factoryboy#47
To fix this problem temporally we can switch to FactoryBoy 2.8.1.