Skip to content

DRF 3.6.3 breaks tests #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mblayman opened this issue May 17, 2017 · 0 comments
Closed

DRF 3.6.3 breaks tests #350

mblayman opened this issue May 17, 2017 · 0 comments
Assignees
@mblayman

Comments

@mblayman
Copy link
Collaborator

Looks like the latest DRF release broke some tests. See encode/django-rest-framework#4222 for details.

Related breakage: https://travis-ci.org/django-json-api/django-rest-framework-json-api/jobs/233215665
@mblayman mblayman self-assigned this May 17, 2017
mblayman added a commit to mblayman/django-rest-framework-json-api that referenced this issue May 17, 2017
@mblayman
Fix tests to work with DRF 3.6.3.
8926754 
Fixes django-json-api#350
@mblayman mblayman mentioned this issue May 17, 2017
Merged
mblayman added a commit that referenced this issue May 17, 2017
@mblayman
Fix tests to work with DRF 3.6.3. (#351)
a12d98d 
* Fix tests to work with DRF 3.6.3.

Fixes #350

* Avoid raising a KeyError.

This test checked a condition that created a RuntimeError in the past.
In this newer version of DRF, the field is not included so the key
should be ignored when not present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mblayman mblayman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mblayman