Skip to content

missing DjangoFilterBackend.get_schema_operation_parameters() #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
n2ygk opened this issue May 30, 2019 · 4 comments · Fixed by #772
Closed

missing DjangoFilterBackend.get_schema_operation_parameters() #644

n2ygk opened this issue May 30, 2019 · 4 comments · Fixed by #772
Assignees
@n2ygk
Labels
enhancement

Comments

@n2ygk
Copy link
Contributor

n2ygk commented May 30, 2019

Upstream DRF's generateschema requires filter backends to have a get_schema_operation_parameters() in order to generate a query parameter schema. This is missing from DjangoFilterBackend. This is a pre-req for #604.
@n2ygk n2ygk self-assigned this May 30, 2019
@n2ygk
Copy link
Contributor Author

n2ygk commented May 30, 2019

Missing in upstream carltongibson/django-filter#1083

@sliverc
Copy link
Member

sliverc commented May 30, 2019

I just wanted to write the same thing... 😄 Can we close this issue then and reference upstream issue in #604 ?

@n2ygk
Copy link
Contributor Author

n2ygk commented May 30, 2019

moved to #604.

@n2ygk n2ygk closed this as completed May 30, 2019
@n2ygk
Copy link
Contributor Author

n2ygk commented May 31, 2019

Actually I'm going to reopen this as the upstream still needs DJA customization for wrap the filter names in filter[]

@n2ygk n2ygk reopened this May 31, 2019
@n2ygk n2ygk mentioned this issue May 31, 2019
Closed
5 tasks
@sliverc sliverc mentioned this issue Oct 6, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n2ygk n2ygk

Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@sliverc @n2ygk