Skip to content

Adjusted to only use f-strings for slight performance improvement #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2021
Merged

Adjusted to only use f-strings for slight performance improvement #1028

merged 2 commits into from
Dec 14, 2021

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 14, 2021

Description of the Change

Since we dropped Python 3.5 support let's make use of the new f-string feature in Python 3.6+ for code improvement and readability.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk December 14, 2021 07:06
n2ygk
n2ygk requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sliverc Please fix the CHANGELOG.md conflicts resulting from the prior PR being merged.

@sliverc sliverc requested a review from n2ygk December 14, 2021 16:09
@n2ygk n2ygk merged commit 0c179d7 into django-json-api:master Dec 14, 2021
@sliverc sliverc deleted the f_strings branch December 14, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @n2ygk