Added support for 3.13 #1256
Merged
Added support for 3.13 #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliverc
force-pushed
the
python_3_13
branch
2 times, most recently
from
8596f7e
to
8107ab1
Compare
This will only be supported on Django 5.1 and above. see https://forum.djangoproject.com/t/backport-python-3-13-support-in-django-5-0/34671
so only master till it is released. see https://github.com/encode/django-rest-framework/pull/9527/files
n2ygk
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Python 3.13 will only be supported by Django 5.1 and above.
Currently, 3.13 has not been released yet on Github so using Python 3.13-dev. This should be removed once it is released.
Additionally, DRF made a change to how description is retrieved. Tests with DRF 3.15 are failing because of that, so only testing on drfmaster. However, as schema support is deprecated anyway, I suppose we can still mark DJA to support Python 3.13 before DRF releases another version.
As only drfmaster is tested for Python 3.13 it does not make sense to ignore it. As of the issue we had in #1251 I removed all ignores, so we get notified if something goes wrong.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS