Add Django Debug Toolbar, and add a failing test for query explosions #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance expectations (also flake8)
|
Hey @aidanlister! Thanks for the PRs. I'm excited to get some of these performance rough edges smoothed out. Both of the current PRs ( #364 and #365 ) have failing builds, if you can fix those things up, I can take a look at the code once the CI build is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Django Debug Toolbar, makes the example app easier to performance test in the browsable API (e.g. eliminates extra queries caused by lack of ordering on the models, and stops the browsable forms from making queries) and adds a failing test for query explosions. I also flake8'd a few files (mainly fixed import * stuff).
This should give everyone a pretty clean base to play with JSON API with.