Skip to content

Release 2.5.0 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jul 10, 2018

It's time again for another release as quite a few important fixes/changes have been added.

@mblayman
This will be the first release I will make. You have already documented concerning twine. I assume I do not have pypi rights for this project yet though?
Also another question how do we update Read The Docs?

Thanks for your feedback.

@sliverc sliverc requested a review from mblayman July 10, 2018 08:20
@sliverc sliverc force-pushed the preparing_release_2_5_0 branch from a6fbd43 to 4b1c45a Compare July 10, 2018 08:24
@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          54       54           
  Lines        2858     2858           
=======================================
  Hits         2649     2649           
  Misses        209      209
Impacted Files Coverage Δ
rest_framework_json_api/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e7738...0846624. Read the comment docs.

Copy link
Collaborator

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sliverc I thought that Read the Docs was updating after each master merge. I think we'll need some input from @jerel to see what's going on there. I presume he has the RTD configuration under his account. Maybe that linkage broke when we switched from the develop branch to master.

Do you have a PyPI account and username? I can try to add you. If I find that I don't have permission, we can poke @jerel about that too.

@sliverc
Copy link
Member Author

sliverc commented Jul 10, 2018

@mblayman My user name on PyPI is sao.

@mblayman
Copy link
Collaborator

Looks like I don't have permission to add you as a maintainer.

image

@jerel, can you give us a hand by adding a sao as a maintainer to DJA on PyPI?

@jerel
Copy link
Member

jerel commented Jul 10, 2018

done

@sliverc
Copy link
Member Author

sliverc commented Jul 10, 2018

Thanks @jerel in terms of Read The Docs it seems that latest is still linked to develop branch. Could you change this to master branch? I do not seem to have access to edit it.

@jerel
Copy link
Member

jerel commented Jul 10, 2018

also done, let me know if either of you have a ReadTheDocs account and I'll add you

@sliverc
Copy link
Member Author

sliverc commented Jul 10, 2018

Thanks @jerel My read the docs account is sliverc

@sliverc sliverc force-pushed the preparing_release_2_5_0 branch from 4b1c45a to 0846624 Compare July 11, 2018 14:10
@sliverc sliverc merged commit 2619f45 into django-json-api:master Jul 11, 2018
@sliverc sliverc deleted the preparing_release_2_5_0 branch July 11, 2018 14:22
@mblayman
Copy link
Collaborator

👏 Nice work, @sliverc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants