Skip to content

Document goals of Django REST Framework JSON API #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jul 24, 2018

Add goals of Django RESTFramework JSON API which we can reference to and use as basis in discussions of issues and pull requests.

This goals are extracted from following comment made by @mblayman. I can fully agree to those points and think it is important to document those goals in a easy to find place.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc requested review from mblayman and n2ygk July 24, 2018 06:59
@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #447   +/-   ##
======================================
  Coverage    93.1%   93.1%           
======================================
  Files          54      54           
  Lines        3000    3000           
======================================
  Hits         2793    2793           
  Misses        207     207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7f830...f7f8383. Read the comment docs.

Copy link
Collaborator

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think adding some goals explicitly to the docs is a great idea.


1. Support the [JSON API](http://jsonapi.org/) spec to compliance
2. Be as compatible with Django REST Framework as possible
e.g. issues in Django REST Framework should be fixed upstream and not worked around in DJA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks good in the plain text, but I think it won't format well in the final documentation. It would look like "... as possible e.g. issues in Django...." I think the line should be wrapped with parentheses.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@n2ygk n2ygk merged commit 1e54ced into django-json-api:master Jul 24, 2018
@n2ygk n2ygk added this to the 2.6.0 milestone Sep 18, 2018
@sliverc sliverc deleted the goals branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants