Skip to content

JSONAPI prefix for paginators #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Aug 21, 2018

Description of the Change

Per a discussion with @sliverc, renamed recently-added pagination classes from JsonApi-prefix to JSONAPI-prefix. This includes new deprecation warnings for the old names.

I also added a minor fix to tox.ini not to run flake8 on the entire directory but only the relevant files.
You can cherry-pick that out if you prefer it not to be part of this PR.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added (no change; just class renamed)
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

(This replaces #458 where I messed up the history by rebasing incorrectly.)

@n2ygk n2ygk requested a review from sliverc August 21, 2018 21:14
@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #463 into master will increase coverage by 0.03%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   93.33%   93.37%   +0.03%     
==========================================
  Files          56       56              
  Lines        3164     3183      +19     
==========================================
+ Hits         2953     2972      +19     
  Misses        211      211
Impacted Files Coverage Δ
rest_framework_json_api/pagination.py 95.31% <100%> (+0.97%) ⬆️
example/tests/unit/test_pagination.py 100% <100%> (ø) ⬆️
example/views.py 91.89% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d2236...f04f95e. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@sliverc sliverc merged commit e6290af into django-json-api:master Aug 22, 2018
@n2ygk n2ygk deleted the std-JSONAPI-prefix branch August 22, 2018 13:25
n2ygk added a commit to n2ygk/django-rest-framework-json-api that referenced this pull request Aug 30, 2018
@n2ygk n2ygk mentioned this pull request Aug 31, 2018
5 tasks
@n2ygk n2ygk added this to the 2.6.0 milestone Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants