Skip to content

renamed JSONAPIOrderingFilter to OrderingFilter #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Sep 13, 2018

Fixes #471

Description of the Change

Remove "JSONAPI" prefix from OrderingFilter before it is released.

No CHANGELOG.md changes needed as it's covered by "Add optional jsonapi-style filter backends. See usage docs"

Checklist

  • PR only contains one change (considered splitting up PR)
  • documentation updated
  • author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc September 13, 2018 18:52
@sliverc sliverc merged commit 59c439d into django-json-api:master Sep 14, 2018
@sliverc sliverc added this to the 2.6.0 milestone Sep 14, 2018
@sliverc
Copy link
Member

sliverc commented Sep 14, 2018

Well spotted. I have created a milestone 2.6.0 so if you find any other issue which should be fixed before release 2.6.0 you can assign milestone to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

naming style: JSONAPI prefix or not?
2 participants