Use flake8-isort to check isort #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n2ygk
requested changes
Oct 13, 2018
n2ygk
reviewed
Oct 13, 2018
README.rst
Outdated
| @@ -126,19 +126,18 @@ Running the example app | |||
| Browse to http://localhost:8000 | |||
|
|
|||
|
|
|||
| Running Tests | |||
| ^^^^^^^^^^^^^ | |||
| Running Tests and linitng | |||
There was a problem hiding this comment.
Please correct spelling of "linting"
This combines flak8 and isort environment and simplifies flake8 and isort tests for developers.
n2ygk
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
Description of the Change
This combines flak8 and isort environment and simplifies flake8 and isort tests for developers.
Checklist
CHANGELOG.mdAUTHORSDeliberately left out CHANGELOG entry as this change is only of interest to contributors and not to users of DJA.