-
Notifications
You must be signed in to change notification settings - Fork 300
add drf39 and drfmaster tests #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess on the drfmaster tests we will see how helpful they really are.
Also another question is DRF 3.9 now also support Django 2.1 and Python 3.7. Should we add this in this PR or follow up later on?
@sliverc Yes, I'll add py37 and django21 |
Will need to figure out what the magic incantation is to get Python 3.7 made available in Travis:
FWIW all the tox Python 3.7 stuff passed locally using MacOS Mojave, Xcode10 and |
@sliverc I'm at a loss here... It looks like even though the distro is xenial, travis is still looking in the trusty archive (14.04 instead of 16.04). |
I'll try adding "sudo: required" and see if that fixes it. See https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures |
@sliverc Ready for (hopefully final) review (and merge). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
I think we should only test though what DRF officially supports and not more. See my comments what needs to be adjusted for this.
.travis.yml
Outdated
- python: 3.6 | ||
env: TOXENV=py36-df20-django21-drf37 | ||
- python: 3.6 | ||
env: TOXENV=py36-df20-django21-drf38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django 2.1 is only supported with DRF 3.9 so we should remove this.
@sliverc You don't think it's a good idea to test against master in order to get an early heads-up as 3.9 dot releases become available? It's an allowed failure so won't break travis builds. Personally I would have felt better about not having to rush to get drf39 tests added here after 3.9 was published. Luckily nothing broke. |
@n2ygk Example: This way we can reduce the size of the matrix and also tell the user what is officially supported when the look at the CI build and a specific DRF version. Hope this clarifies. |
only approved combinations of Django, DRF, Python
Thanks. LGTM. Merging. |
Fixes #486
Description of the Change
Add test matrix entries for drf3.9 and drf master branch (so we can get an early look at 3.10+).
Checklist
CHANGELOG.md
AUTHORS