Skip to content

add drf39 and drfmaster tests #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 23, 2018
Merged

add drf39 and drfmaster tests #498

merged 7 commits into from
Oct 23, 2018

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Oct 18, 2018

Fixes #486

Description of the Change

Add test matrix entries for drf3.9 and drf master branch (so we can get an early look at 3.10+).

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc self-requested a review October 18, 2018 15:43
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess on the drfmaster tests we will see how helpful they really are.

Also another question is DRF 3.9 now also support Django 2.1 and Python 3.7. Should we add this in this PR or follow up later on?

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 18, 2018

@sliverc Yes, I'll add py37 and django21

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 18, 2018

Will need to figure out what the magic incantation is to get Python 3.7 made available in Travis:

3.7 is not installed; attempting download
Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/python-3.7.tar.bz2
$ curl -sSf -o python-3.7.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 403 Forbidden
Unable to download 3.7 archive. The archive may not exist. Please consider a different version.

FWIW all the tox Python 3.7 stuff passed locally using MacOS Mojave, Xcode10 and pyenv install -v 3.7.0 (although not super-smoothly - pyenv/pyenv#1219)

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 18, 2018

@sliverc I'm at a loss here... It looks like even though the distro is xenial, travis is still looking in the trusty archive (14.04 instead of 16.04).

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 18, 2018

I'll try adding "sudo: required" and see if that fixes it. See https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 18, 2018

@sliverc Ready for (hopefully final) review (and merge).

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

I think we should only test though what DRF officially supports and not more. See my comments what needs to be adjusted for this.

.travis.yml Outdated
- python: 3.6
env: TOXENV=py36-df20-django21-drf37
- python: 3.6
env: TOXENV=py36-df20-django21-drf38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django 2.1 is only supported with DRF 3.9 so we should remove this.

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 23, 2018

@sliverc You don't think it's a good idea to test against master in order to get an early heads-up as 3.9 dot releases become available? It's an allowed failure so won't break travis builds. Personally I would have felt better about not having to rush to get drf39 tests added here after 3.9 was published. Luckily nothing broke.

@sliverc
Copy link
Member

sliverc commented Oct 23, 2018

@n2ygk
My comment was not concerning drfmaster tests (those need to be tested against combos which are officially supported by the previous release I guess) but the test with official DRF releases.

Example:
a combo Django 2.1 + Python 3.6 and DRF 3.7 should not be tested in our matrix as DRF states that Django 2.1 is only supported from DRF 3.9 onward.

This way we can reduce the size of the matrix and also tell the user what is officially supported when the look at the CI build and a specific DRF version.

Hope this clarifies.

only approved combinations of Django, DRF, Python
@sliverc
Copy link
Member

sliverc commented Oct 23, 2018

Thanks. LGTM. Merging.

@sliverc sliverc merged commit d0debda into django-json-api:master Oct 23, 2018
@sliverc sliverc mentioned this pull request Oct 24, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants