Fix related resource on inherited polymorphic model #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a related resource to an inherited polymorphic model, that is absent on the base model, the related resource type is incorrectly resolved in get_related_resource_type. Introduce a LabResults model to the example code and add it as a related resource on the ResearchProjectSerializer to provoke an error. This already causes the test-suite to fail, so no new test has been added.
In get_related_resource_type, check if the parent_serializer is polymorphic. If so, resolve the parent_model using the parent serializer's instance to correctly handle related resources on polymorphic models.
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 97.15% 97.16%
=======================================
Files 54 55 +1
Lines 2816 2825 +9
=======================================
+ Hits 2736 2745 +9
Misses 80 80
Continue to review full report at Codecov.
|
sliverc
approved these changes
Feb 7, 2020
|
Thanks for the quick merge, your work is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621
Description of the Change
When adding a
ResourceRelatedFieldto a serializer that is included in thepolymorphic_serializerslist of a polymorphic serializer, the
parent_modelis not correctly resolved inget_related_resource_type: instead of resolving to the inherited type, the base type is resolved. This can cause anAttributeErrorif the field in question is not present on the base model.We ran into this, and then found the closed and seemingly abandoned issue referenced above. This PR implements the fix suggested by the original author, who deserves all the credit. The example code has been expanded to trigger the error when running the test-suite.
Thanks in advance for your time and please let us know if you have any suggestions for improvement.
Checklist
unit-test addedtest-suite failure is introduced, but no unit-test addeddocumentation updatedunnecessaryCHANGELOG.mdupdated (only for user relevant changes)AUTHORS