Skip to content

Add warning to docs on permission check with related urls #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 12, 2020

Fixes #864

Description of the Change

Add notice to make sure users understand permission model when using related urls.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #872 (5a284a0) into master (a59c96f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          60       60           
  Lines        3319     3319           
=======================================
  Hits         3244     3244           
  Misses         75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdceb0a...2de3c0a. Read the comment docs.

@sliverc sliverc requested a review from n2ygk December 15, 2020 18:03
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

@n2ygk n2ygk merged commit 848d850 into django-json-api:master Dec 28, 2020
@n2ygk
Copy link
Contributor

n2ygk commented Dec 28, 2020

force merging per #877

@sliverc sliverc deleted the related_urls_permisison_doc branch December 28, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission checks on related resources not executed
2 participants