Check for reserved field names in serializer meta class #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes django-json-api#518 Fixes django-json-api#710 This is to avoid an incomprehensible exception during runtime when either meta or results is used as a field name.
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
=======================================
Coverage 96.82% 96.83%
=======================================
Files 65 65
Lines 3906 3914 +8
=======================================
+ Hits 3782 3790 +8
Misses 124 124
Continue to review full report at Codecov.
|
n2ygk
approved these changes
Oct 6, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #518
Fixes #710
Description of the Change
This is to avoid an incomprehensible exception during runtime when either meta or results is used as a field name.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS