RTFD builds failing since Django 4.0 release

[n2ygk]

Describe the bug

readthedocs.io builds have been failing since 10 December 2021.

To Reproduce

Take a look at https://readthedocs.org/projects/django-oauth-toolkit/builds/15504196/

Expected behavior

Builds should succeed

Version

1.5.0, 1.6.0

• I have tested with the latest published release and it's still a problem.
• I have tested with the master branch and it's still a problem.

Additional context

The likely cause is the 7 December 2021 release of Django 4.0

[n2ygk]

The first rtfd build to fail corresponds to this commit by @pcarn which removes import django from __init__:

commit 345122881424897a2907312db52fafad9bbaa5f1
Author: Peter Carnesciali <pcarn9@gmail.com>
Date:   Fri Dec 10 10:05:37 2021 -0600

    Removes default_app_config for Django Deprecation Warning (#1035)
    
    * Removes default_app_config for Django Deprecation Warning
    
    * Update AUTHORS
    
    * Update __init__.py
    
    * import django
    
    * Install django so tox tests work
    
    * Pin mistune to fix docs

(dot-venv) django-oauth-toolkit$ git diff 345122881424897a2907312db52fafad9bbaa5f1 345122881424897a2907312db52fafad9bbaa5f1~1
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index f1f7342..7d257b4 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -37,7 +37,7 @@ jobs:
     - name: Install Python dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install --upgrade tox tox-gh-actions django
+        python -m pip install --upgrade tox tox-gh-actions
 
     - name: Tox tests
       run: |
diff --git a/AUTHORS b/AUTHORS
index e47665e..6896048 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -46,7 +46,6 @@ Michael Howitz
 Paul Dekkers
 Paul Oswald
 Pavel Tvrdík
-Peter Carnesciali
 Rodney Richardson
 Rustem Saiargaliev
 Sandro Rodrigues
diff --git a/docs/requirements.txt b/docs/requirements.txt
index 69501a2..c1f7269 100644
--- a/docs/requirements.txt
+++ b/docs/requirements.txt
@@ -1,5 +1,4 @@
 Django>=3.0,<3.1
 oauthlib>=3.1.0
 m2r>=0.2.1
-mistune<2
 .
diff --git a/oauth2_provider/__init__.py b/oauth2_provider/__init__.py
index 6ae4b30..ebb0b28 100644
--- a/oauth2_provider/__init__.py
+++ b/oauth2_provider/__init__.py
@@ -1,7 +1,3 @@
-import django
-
-
 __version__ = "1.5.0"
 
-if django.VERSION < (3, 2):
-    default_app_config = "oauth2_provider.apps.DOTConfig"
+default_app_config = "oauth2_provider.apps.DOTConfig"
diff --git a/tox.ini b/tox.ini
index ebd9ffb..8371aab 100644
--- a/tox.ini
+++ b/tox.ini
@@ -64,7 +64,6 @@ deps =
     sphinx<3
     oauthlib>=3.1.0
     m2r>=0.2.1
-    mistune<2
     sphinx-rtd-theme
     livedocs: sphinx-autobuild
     jwcrypto

not sure how/why the tox tests didn't work before this change...

[pcarn]

That commit is showing in reverse, it was adding django to __init__, to check the version.

3451228

[pcarn]

I don't have access to those builds, but installing django as part of the build setup should fix it.

[n2ygk]

That commit is showing in reverse, it was adding django to __init__, to check the version.

3451228

D'oh!

[n2ygk]

I don't have access to those builds, but installing django as part of the build setup should fix it.

Still trying to understand what changed since it was building fine up until 10 December.

[pcarn]

What changed is the import django line I added to __init__.py, the doc build is now failing because django can't be imported.

Django is in docs/requirements.txt though, so I thought that should work. Perhaps the init is happening before it's being installed or something.

[n2ygk]

@pcarn Since merging #1048 the docs build is now reporting a new missing package:

ModuleNotFoundError: No module named 'setuptools._distutils'

[pcarn]

Where is the config for this command in that docs build?

/home/docs/checkouts/readthedocs.org/user_builds/django-oauth-toolkit/envs/latest/bin/python -m pip install --upgrade --no-cache-dir -I mock==1.0.1 pillow==5.4.1 alabaster>=0.7,<0.8,!=0.7.5 commonmark==0.8.1 recommonmark==0.5.0 sphinx<2 sphinx-rtd-theme<0.5 readthedocs-sphinx-ext<2.2

Adding django to that might solve it.

[n2ygk]

I've got to take a deeper look, I'm bugging you since the first time the builds started failing was with your commit so something changed at that point. And the error change to setuptool missing once you moved the django dependency in the tox.ini.

I checked the rtfd config and it didn't have docs/requirements.txt, which is weird since how was it working before?

[pcarn]

I think it worked before because django wasn't a direct dependency for it, and I'm guessing setuptools is downstream from that.

I don't have access to the config for the docs build, so I can only guess on what needs to change there.

[n2ygk]

Fixed by #1050