Skip to content

Update contribution guidelines to request PR review by project team. #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Update contribution guidelines to request PR review by project team. #1044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ When you begin your PR, you'll be asked to provide the following:
If your PR is not yet ready to be merged mark it as a Work-in-Progress
By prepending `WIP:` to the PR title so that it doesn't get inadvertently approved and merged.

The repo managers will be notified of your pull request and it will be reviewed, in the meantime you can continue to add
Make sure to request a review by assigning Reviewer `jazzband/django-oauth-toolkit`.
This will assign the review to the project team and a member will review it. In the meantime you can continue to add
commits to your topic branch (and push them up to GitHub) either if you see something that needs changing, or in
response to a reviewer's comments. If a reviewer asks for changes, you do not need to close the pull and reissue it
after making changes. Just make the changes locally, push them to GitHub, then add a comment to the discussion section
Expand Down