Skip to content

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Dec 22, 2021

Fixes #

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 1.6.1 milestone Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (6017f07) to head (714455a).
Report is 223 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          31       31           
  Lines        1756     1756           
=======================================
  Hits         1697     1697           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n2ygk n2ygk changed the title WIP: Fix changelog typo from 1.6.0 and start changelog for 1.6.1 WIP: 1.6.1 release Dec 22, 2021
@n2ygk n2ygk changed the title WIP: 1.6.1 release 1.6.1 release Dec 23, 2021
@n2ygk
Copy link
Contributor Author

n2ygk commented Dec 23, 2021

@Andrew-Chen-Wang Let's just get 1.6.1 out there real quick and the we can work on #1055

Copy link
Contributor

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README's RST link in the explanation doesn't have an underscore after the ```. Also, not sure what packaging info changed? Was it the docs?

Copy link
Contributor

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be gone for next few hours, so besides that one README comment, LGTM

@n2ygk
Copy link
Contributor Author

n2ygk commented Dec 23, 2021

The README's RST link in the explanation doesn't have an underscore after the ```. Also, not sure what packaging info changed? Was it the docs?

Yeah, Getting RTFD back working and highlighting the warning about Django 4.0.0 probably not quite ready and a contributing update asking people to request a PR from jazzband/django-oauth-toolkit.

Please consider joining that team! See https://jazzband.co/projects/django-oauth-toolkit/join

django-oauth-toolkit$ git diff --name-only 1.6.0
.github/workflows/test.yml
.readthedocs.yml
CHANGELOG.md
README.rst
docs/contributing.rst
docs/requirements.txt
oauth2_provider/__init__.py
tox.ini

@n2ygk n2ygk merged commit f111812 into django-oauth:master Dec 23, 2021
@n2ygk n2ygk deleted the release1.6.1 branch December 23, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants