Skip to content

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Mar 18, 2022

Fixes #1104

Description of the Change

Remove support for insecure urn:ietf:wg:oauth:2.0:oob and urn:ietf:wg:oauth:2.0:oob:auto which are replaced
by RFC 8252 "OAuth 2.0 for Native Apps" BCP. Google has deprecated use of oob with a final end date of 2022-10-03.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added removed
  • documentation updated (oob support was never documented)
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from a team March 18, 2022 20:50
@n2ygk n2ygk added this to the 2.0.0 milestone Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1124 (b5188ee) into master (e761ebc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   96.62%   96.59%   -0.03%     
==========================================
  Files          32       32              
  Lines        1806     1794      -12     
==========================================
- Hits         1745     1733      -12     
  Misses         61       61              
Impacted Files Coverage Δ
oauth2_provider/views/base.py 97.58% <100.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e761ebc...b5188ee. Read the comment docs.

@n2ygk n2ygk merged commit fc291ce into django-oauth:master Mar 19, 2022
@n2ygk n2ygk deleted the remove_oob branch December 20, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate oob PR #774

2 participants