Clear expired ID tokens from database #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cleartokens` management command removed expired refresh tokens and associated access tokens but kept expired ID tokens in the database. Remove ID tokens when the associated access and refresh tokens are cleared. Preserve expired ID tokens until the associated access token is deleted to keep relationships intact and not trigger delete cascades. Fixes django-oauth#1222
Pankrat
force-pushed
the
clear-expired-id-tokens
branch
from
0a4382d to
80f8af2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 26 26
Lines 1317 1317
=======================================
Hits 1267 1267
Misses 50 50 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
n2ygk
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cleartokensmanagement command removed expired refresh tokens and associated access tokens but kept expired ID tokens in the database.Remove ID tokens when the associated access and refresh tokens are cleared.
Preserve expired tokens until the associated access token is deleted to keep relationships intact and not trigger delete cascades.
Fixes #1222
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS