Adds the ability to define how to store a user #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
- Coverage 97.56% 97.44% -0.12%
==========================================
Files 32 32
Lines 2132 2076 -56
==========================================
- Hits 2080 2023 -57
- Misses 52 53 +1 ☔ View full report in Codecov by Sentry. |
|
@1vank1n sorry for the delay in looking at this. It seems like a reasonable thing to have. Please rebase and do the checklist stuff:
|
for more information, see https://pre-commit.ci
1vank1n
force-pushed
the
add-user-layer-in-validator
branch
from
c326d04 to
cc3620f
Compare
I've added it. If it needs anything, please let me know |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Faced a problem that it is not possible now to specify the user's storage location in the validator. This functionality is now a separate public method that can be easily reused. If you agree with me, I will implement the rest of the checklist items (tests, docs, etc.).
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS