Fix non rotating refresh tokens #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the fields attribute is prohibited.
Adds indexes to the OAuth2 related models.
ModelFormMixin (base class of ApplicationUpdate) without the fields attribute is prohibited.
more flexible for related name of user field in AbstractApplication model
…t into davecap-revoke-keys
This breaks OAuthLib when `rotate_refresh_token()` returns `False`
…nt-refresh-tokens
|
@zuzelvp, While the refresh token is deleted here, isn't the same one immediately created right after here? OAuthLib is the library that determines the new refresh token. |
|
@conradev yes, I noticed after posting and deleted my previous comment ;) |
|
@conradev FYI I am cool with either solution (i.e., removing the line that changes request.refresh_token or restoring it later). Feel free to reuse the tests on your pull request. |
zuzelvp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #138