wrong exception is sent due to separator being hard coded to "?" when raising an error #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause the redirect_uri may already contain URL parameters
|
Changes look good to me. Do you mind to fix the tests? |
|
sorry about that, I will check out the tests today! |
|
tests are running now, should be fixed! |
There was a problem hiding this comment.
sorry for being pedantic but I don't like except: pass very much ;)
What about something like:
redirect_uri = oauthlib_error.redirect_uri or ""
separator = '&' if '?' in redirect_uri else '?'Also, I guess a test case checking the double ? problem (a test that fails without your patch) should be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks for the presence of a question mark in the URI and changes the separator accordingly so as to not put two questions marks in the URI.
fixes #238