Fix for issue #235 (urn:ietf:wg:oauth:2.0:oob support) #774
Conversation
…ort for urn:ietf:wg:oauth:2.0:oob and urn:ietf:wg:oauth:2.0:oob:auto redirect URLs.
Pull Request Test Coverage Report for Build 1248
💛 - Coveralls |
See https://github.com/googleapis/oauth2client/blob/master/oauth2client/client.py#L618 for more information about these fields.
marnanel
changed the title
it's not used when we're returning a token
…zation_code.py. test_oob_authorization.py, which contained earlier versions of these, deleted.
|
Coverage is now increasing. |
|
In the process of trying to document what's in the next release (#785) I googled this feature and see discussion of it being a non-standard google-only deprecated practice that is replaced by RFC 8252 which offers a few mechanisms to get the same result for a command-line app. Consider deprecating this in a future release. I'll put a warning in the Changelog. |
|
@n2ygk Is the protocol itself deprecated, or merely Google’s usage of the Windows title bar as the communication channel? The django-oauth-toolkit implementation does not use the title bar. It still seems like a really useful mechanism for native applications that can’t (due to privilege separation) or won’t (due to portability concerns) do things like register a URI protocol handler or open a firewall port. Also, it’s not Google-only: |
5 participants
This adds support for the "urn:ietf:wg:oauth:2.0:oob" and "urn:ietf:wg:oauth:2.0:oob:auto" URNs, as discussed in issue #235 .
The dict returned by "urn:ietf:wg:oauth:2.0:oob:auto" needs work because it's currently missing several members which are inspected by the standard client. I'm submitting this PR now to check whether I'm barking up the wrong tree further up, so to speak.