update namespace error in example #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the app_name attribute is not set in the included module (oauth2_provider), we cannot directly include endpoints with the namespace oauth2_provider. We need to pass in a tuple of the endpoints and app-name instead. Document the same in the tutorial example.
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 31 31
Lines 1704 1704
=======================================
Hits 1646 1646
Misses 58 58 Continue to review full report at Codecov.
|
|
Commit? |
|
Looks like @auvipy merged this early so it's part of release 1.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the app_name attribute is not set in the included module (oauth2_provider), we cannot directly include endpoints with the namespace oauth2_provider.
We need to pass in a tuple of the endpoints and app-name instead. Document the same in the tutorial example.
Description of the Change
Update tutorial documentation regarding namespace inclusion
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS