Handle transformed assets URL #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
reviewed
Apr 1, 2024
webpack_loader/utils.py
Outdated
| @@ -124,3 +124,10 @@ def get_static(asset_name, config='DEFAULT'): | |||
| public_path = getattr(settings, 'STATIC_URL') | |||
|
|
|||
| return '{0}{1}'.format(public_path, asset_name) | |||
|
|
|||
| def get_asset(asset_name, config='DEFAULT'): | |||
There was a problem hiding this comment.
Please add a docstring similar to the one from get_static, but clarify why this is different.
fjsj
reviewed
Apr 1, 2024
fjsj
reviewed
Apr 1, 2024
webpack_loader/loaders.py
Outdated
| asset = next((x for x in assets if x.get("sourceFilename") == name), None) | ||
| if not asset: | ||
| asset = next((x for x in assets if x["name"] == name), None) | ||
| return asset |
There was a problem hiding this comment.
I think this should read like this:
def get_asset_by_source_filename(self, name):
files = self.get_assets()["assets"]
return next((x for x in files if x.get("sourceFilename") == name), None)
fjsj
requested changes
Apr 1, 2024
batistadasilva
force-pushed
the
webpack-asset
branch
from
7d52a83
to
889c5b4
Compare
|
@fjsj Thanks for the review! Let me know if all changes fit the requirements |
Adding the following template tag
```
{% webpack_asset 'path/to/original/file' %}
```
Fixes django-webpack#343
Depends on django-webpack/webpack-bundle-tracker#125
batistadasilva
force-pushed
the
webpack-asset
branch
from
889c5b4
to
65dddf2
Compare
fjsj
reviewed
Apr 2, 2024
| "license": "MIT", | ||
| "devDependencies": { | ||
| "webpack": "^5.91.0", | ||
| "webpack-bundle-tracker": "github:hostnfly/webpack-bundle-tracker#assets-source-filenames", |
|
Released at 3.1.0, thanks again @batistadasilva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following template tag
Fixes #343
Depends on django-webpack/webpack-bundle-tracker#125