Fix type checks for functions passed to async_to_sync/sync_to_async #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristobalJunta
force-pushed
the
main
branch
2 times, most recently
from
c2a893b to
2a7943f
Compare
On Python < 3.8 a functool.partial is not detected as async function, which is due to a bug in inspect module, see https://bugs.python.org/issue33261 This commit adds a proper type check for earlier Python versions and fixes django#251.
|
Lovely, thanks so much for getting this done. |
adamchainz
referenced
this pull request
Apr 7, 2021
Detecting if a function is async in Python has a lot of false negatives, so this is a lot safer while async code we call all makes sure it has the coroutinefunction flag set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python < 3.8 a functool.partial is not detected as async function, which is due to a bug in inspect module, see: https://bugs.python.org/issue33261
This commit adds a proper type check for earlier Python versions and fixes #251
Idea taken from pgjones' comment.