add modernizr svg class manually to utilize SVGs in CSS #173 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernizr JavaScript library was removed in 43d9616 due to the fact that the CSS class `mdzr-svg` is missing from the markup and the SVG images defined in the output.css are no longer used. This leads to visual regression compared to other parts of the djangoproject.com website on high-dpi devices (blurry images), i.e. header/footer logos. Other Modernizr classes used in code.djangoproject.com seem to be `.mdzr-borderradius`, `.mdzr-cssanimations` but those appear only in the output.css and seem to be used on the djangoproject.com home page and not here. `.mdzr-no-borderradius` is used as well, but that seems irrelevant, since all browsers should support border-radius.
|
Thanks so much for your PR and your thorough analysis! I took the liberty of tweaking the commit message before merging. This change will be deployed within a few days hopefully, and the website will be pretty again thanks to you 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernizr JavaScript library was removed in 43d9616 due to the fact that the CSS class
mdzr-svgis missing from the markup and the SVG images defined in the output.css are no longer used. This leads to visual regression compared to other parts of the djangoproject.com website on high-dpi devices (blurry images), i.e. header/footer logos.Other Modernizr classes used in code.djangoproject.com seem to be
.mdzr-borderradius,.mdzr-cssanimationsbut those appear only in the output.css and seem to be used on the djangoproject.com home page and not here..mdzr-no-borderradiusis used as well, but that seems irrelevant, since all browsers should support border-radius.