Fixed 22336 -- Add pattern match for path to match subdirectories #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks infraredgirl for the report and Claude Paroz for the previous fix in 20422. I added an additional check to match the given patterns against the full path and broke tests out to for checking filepatterns and directory patterns.
|
what's the status on this ticket? we ran into the same problem yesterday and it would be great if this can be fixed @claudep ping |
|
I'm about to commit the patch slightly amended. @arthurk: you can also review patch yourself, and mark them "Ready for checkin" on the ticket if you think it's really ready. |
|
Committed in 8fe4068, thanks! |
|
@claudep Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks infraredgirl for the report and Claude Paroz for the previous
fix in 20422. I added an additional check to match the given patterns
against the full path and broke tests out to for checking filepatterns
and directory patterns.