-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1633: Update Django dependency to version 5.1.5 #1792
Conversation
6cf6346
to
8e38471
Compare
8e38471
to
acb2680
Compare
acb2680
to
ca0c8ae
Compare
@bmispelon |
The test failure looks like it might have something to do with You might be able to reproduce the failure locally by running all tests (not just a subset). |
I'm trying to reproduce it locally but turned out creating the local env was harder than I remember, and docker setup is not ready for local testing. When I find a quick solution on this, I'll be creating several other issues 🙂 |
It looks like the errors are somehow related to composite PKs, but I thought it was merged after 5.1, and I couldn't find anything related on the 5.1 changelog. I'll try to tackle it another day, but if it's really about composite PKs, I guess it will require bigger changes than I thought. Added another comment on https://github.com/django/djangoproject.com/pull/1479/files#r1924320453 |
Please open an issue for the Readme if you found that something is missing or wrong. Write here if you need help in the local setup. |
Using This points further to something being broken with the |
Don't ask me how it works, but I just pushed a commit that fixes the tests 😅 |
I feel like we pushed the bug into the 5.2 update 😬 but I'm okay with passing tests for now ✨ |
I tried and the I think all is good with this PR now, I'm going to squash all the commits then merge, let's see how the deploy goes 🤞🏻 |
https://docs.djangoproject.com/en/5.1/releases/5.1/
https://docs.djangoproject.com/en/5.1/releases/5.1/#backwards-incompatible-5-1
Resolves #1633