Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced references to #django IRC. #1821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sarahboyce
Copy link
Contributor

@sarahboyce sarahboyce commented Dec 11, 2024

Following https://forum.djangoproject.com/t/proposal-retire-irc/37129 and https://code.djangoproject.com/ticket/35999, these are my suggested updates for the website.

I have chosen to:

@@ -38,7 +38,6 @@ <h2>Get Help</h2>
<ul>
<li><a href="{% url 'document-detail' lang='en' version='stable' url='faq' host 'docs' %}">Getting Help FAQ</a>
</li>
<li><a href="irc://irc.libera.chat/django">#django IRC channel</a></li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmispelon
Copy link
Member

This is looking great, thanks! ✨

Could you split the CoC changes to their own PR? Out of an abundance of caution I'd like to get those changes reviewed by the CoC workgroup (that's the documented process for changes there I believe).

@bmispelon
Copy link
Member

I wonder if this these changes could be made part of #1808 , that would made the review easier probably.

@sarahboyce
Copy link
Contributor Author

Could you split the CoC changes to their own PR? Out of an abundance of caution I'd like to get those changes reviewed by the CoC workgroup (that's the documented process for changes there I believe).

Done #1823

I wonder if this these changes could be made part of #1808 , that would made the review easier probably.

I see, looks like that PR is coc changes only (similar to the new PR #1823) I agree that new PR can be combined with that one to give the CoC team one review. The idea being that the "Django spaces" have been updated to give more common examples.
@ontowhee would you like to do that or shall I?

@ontowhee
Copy link
Contributor

@sarahboyce I can merge #1823 into #1808.

@sarahboyce
Copy link
Contributor Author

sarahboyce commented Dec 12, 2024

@sarahboyce I can merge #1823 into #1808.

Thank you - I will close the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants