Removed loading of deleted list-feature.js from base.html

[bmispelon]

list-feature.js was deleted in af5cd63

[bmispelon]

@adamzap I believe this was the cause of the crash when deploying this (had nothing to do with out deploy script). I should have spotted that during review, sorry.

[pauloxnet]

LGTM

[adamzap]

@bmispelon Wow, I'm not sure how I missed this, sorry about that! I thought we had a test that makes sure collectstatic works in a production-like environment?

This has taught me that require.js fails silently and produced no console output on missing references. Very weird!

[bmispelon]

I thought we had a test that makes sure collectstatic works in a production-like environment?

We have an issue to implement such a test, but it hasn't been done yet: #1831 (there's a PR for that ticket, but it's not in a mergeable state right now and I haven't had time to give feedback on it).

But that wouldn't have caught this issue anyway, since collectstatic would have worked. It might work if we run the test suite with a ManifestStorage for static files (assuming there's at least one test that ends up rendering the base.html).

In any case, that's a failure on the part of our test suite, not on yours. Plus all it did was cost us a few minutes of down time, and then we ended up making our deploy script more robust. Not a bad outcome at all 😁