Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version comparison #147

Closed
wants to merge 1 commit into from
Closed

Improve version comparison #147

wants to merge 1 commit into from

Conversation

iago1460
Copy link
Contributor

The current string comparison doesn't work with django 1.10 version and in other cases.

I am using the parse_version function defined in setuptools to solve this.

@nemesifier
Copy link
Member

Travis build fails and commit author is not set.

@nemesifier nemesifier closed this in 7c63826 Apr 1, 2016
@nemesifier
Copy link
Member

Thanks

@iago1460
Copy link
Contributor Author

iago1460 commented Apr 1, 2016

Thank you , I didn't have time to fix it.

By the way I publish a package extending this library https://github.com/iago1460/django-dynamic-fields maybe it's useful for someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants