Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mainline rust-postgres #1

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Use mainline rust-postgres #1

merged 1 commit into from
Apr 16, 2018

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Mar 12, 2018

No description provided.

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 since the fixes were merged upstream sfackler/rust-postgres#321

@ChristophWurst
Copy link
Contributor

@vorot93 fyi, there are two warnings:

warning: unused import: `tokio_postgres::tls::Handshake`
  --> postgres/src/lib.rs:15:5
   |
15 | use tokio_postgres::tls::Handshake;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

warning: unused import: `std::fmt`
  --> postgres/src/lib.rs:17:5
   |
17 | use std::fmt;
   |     ^^^^^^^^

This also fixes compiler errors I get on the master branch.

@khuey khuey merged commit 609cb7e into djc:master Apr 16, 2018
@khuey
Copy link
Collaborator

khuey commented Apr 16, 2018

Thank you. I reinstated the debug implementation for PostgresConnectionManager and fixed the warnings.

bbigras pushed a commit to bbigras/bb8 that referenced this pull request Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants