Commits on Oct 17, 2024

1. Fix leaky connections …

   Fixes djc#221
   
   It's possible to trigger more approvals than are necessary, in turn
   grabbing more connections than we need. This happens when we drop a
   connection. The drop produces a notify, which doesn't get used until the
   pool is empty. The first `Pool::get()` call on an empty pool will spawn
   an connect task, immediately complete `notify.notified().await`, then
   spawn a second connect task. Both will connect and we'll end up with 1
   more connection than we need.
   
   Rather than address the notify issue directly, this fix introduces some
   bookkeeping that tracks the number of open `pool.get()` requests we have
   waiting on connections. If the number of pending connections >= the
   number of pending gets, we will not spawn any additional connect tasks.

   

   tneely committed Oct 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 382d18b
   • Browse repository at this point

   Copy the full SHA

   382d18b View commit details

   Browse the repository at this point in the history