Refresh Cargo metadata #8
Conversation
Cargo.toml
Outdated
| @@ -1,14 +1,17 @@ | |||
| [package] | |||
| name = "imap-proto" | |||
There was a problem hiding this comment.
I prefer to keep the common order that most packages seem to have, rather than this alphabetized order.
There was a problem hiding this comment.
I prefer to follow a well-defined ordering everywhere possible, but changed it back.
Cargo.toml
Outdated
| authors = ["Dirkjan Ochtman <dirkjan@ochtman.nl>"] | ||
| categories = ["authentication", "email", "encoding", "network-programming", "parser-implementations"] |
There was a problem hiding this comment.
I don't think this crate fits in with the other crates in authentication and encoding. network-programming and parser-implementations look like fine additions, though!
There was a problem hiding this comment.
Removed the bad extra categories.
Cargo.toml
Outdated
| homepage = "https://github.com/djc/imap-proto" | ||
| keywords = ["IMAP", "e-mail", "email"] | ||
| license = "(Apache-2.0 OR MIT)" |
There was a problem hiding this comment.
This is the first time I see this way of writing that, I think the way I had it before is more common (for example, Cargo itself has MIT/Apache-2.0).
There was a problem hiding this comment.
The old notation is ad hoc and its semantics are not standardized, the new is a true license expression. See this rust-lang/cargo#2174, esp. rust-lang/cargo#2174 (comment). Can we use the new one?
There was a problem hiding this comment.
@djc this is the only remaining change TBD.
There was a problem hiding this comment.
I can see value in going with SPDX license expressions, but for now I'd prefer to stay with where the community largely is at the moment, and reconsider this at some point in the future.
Cargo.toml
Outdated
| homepage = "https://github.com/djc/imap-proto" | ||
| keywords = ["IMAP", "e-mail", "email"] |
There was a problem hiding this comment.
Oh, I also don't want to add e-mail here, seeing as there's only one package that currently has e-mail vs 27 that have email. And it looks like crates.io treats keywords as all-lowercase, so I'd want imap here rather than IMAP.
There was a problem hiding this comment.
Okay! I find it sad though to see programmers misspell these words, which are so important for discoverabilty ..
Tweak, sort various fields that relevant for stimulating this project.
|
@djc: All requested changes completed. |
|
Thanks, and sorry for the churn. |
Tweak, sort various fields that relevant for stimulating this project.