Adjust mendes version to 0.5.1 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in #89 were actually semver-compatible, since they merely widen the blanket impl of IntoResponse for Result.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 57.47% 57.47%
=======================================
Files 7 7
Lines 1364 1364
=======================================
Hits 784 784
Misses 580 580 ☔ View full report in Codecov by Sentry. |
valkum
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Are you sure? Reading rust-lang/cargo#8736 and https://github.com/rust-lang/rfcs/blob/master/text/2451-re-rebalancing-coherence.md#effects-on-parent-crates. I don't want to spend time trying to find an example that breaks. Feel free to merge if you think RFC2451 does not apply here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #89 were actually semver-compatible, since they merely widen the blanket impl of IntoResponse for
Result.r? @valkum