Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional arguments to be passed to cloc #22

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Allow additional arguments to be passed to cloc #22

merged 2 commits into from
Nov 22, 2023

Conversation

JHartzer
Copy link
Contributor

This PR would allow additional arguments to be passed to cloc using the options argument. In a workflow, this might look like:

      - name: Count Lines of Code
        uses: djdefi/cloc-action@5.1
        with:
          options: --exclude-lang=HTML --md --report-file=cloc.md

I modified the ENTRYPOINT to allow the optional arguments to be passed to the shell script. I am not familiar with dumb-init so I hope this was the correct way to extend the entrypoint.

@djdefi djdefi added the enhancement New feature or request label Sep 21, 2023
Copy link
Contributor Author

@JHartzer JHartzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition!

@JHartzer
Copy link
Contributor Author

Is there any additional testing or work that you would like to see done before this could get merged in?

1 similar comment
@JHartzer
Copy link
Contributor Author

Is there any additional testing or work that you would like to see done before this could get merged in?

@djdefi
Copy link
Owner

djdefi commented Nov 16, 2023

It doesn't seem to be working as expected based on https://github.com/djdefi/cloc-action/actions/runs/6265243101/job/17013644796#step:5:1 so it needs a bit more tweaking I think to get working fully.

@djdefi
Copy link
Owner

djdefi commented Nov 22, 2023

Actually that may be due to the Action itself running on main not being updated...

@djdefi djdefi merged commit 213f905 into djdefi:main Nov 22, 2023
1 check passed
@JHartzer
Copy link
Contributor Author

JHartzer commented Dec 3, 2023

Ah, sorry I had missed that error originally! Thank you for following up on this, I appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants