Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing Changes for Bevy 0.11-dev #179

Merged
merged 9 commits into from
Jul 8, 2023
Merged

Preparing Changes for Bevy 0.11-dev #179

merged 9 commits into from
Jul 8, 2023

Conversation

flmng0
Copy link
Contributor

@flmng0 flmng0 commented Apr 21, 2023

Hello.

There are some big changes coming in bevy 0.11, which are currently in the main branch of the bevy repo.

For the changes in question, please see bevyengine/bevy#8079 (which I have referenced so many times I remember the number now...).

TL;DR, add[_startup]_system is deprecated in favour of add_systems with an explicit schedule.

The RenderSet of systems also now has it's own schedule (Render).

The changes I've made below make bevy_hanabi fully functional with bevy-0.11-dev (bevy main branch), at the time of writing.

I had to comment out the use of bevy-inspector-egui, unfortunately, since they have not yet updated their plugin.

The changes are pretty simple over-all, but I thought it'd be best to get them working pre-emptively.

Regards,
Tim

@mockersf mockersf mentioned this pull request May 19, 2023
@djeedai djeedai marked this pull request as ready for review July 8, 2023 10:36
@djeedai djeedai added the C - breaking change A breaking API or behavior change label Jul 8, 2023
@djeedai
Copy link
Owner

djeedai commented Jul 8, 2023

Thanks a lot @flmng0 for this, this is extremely valuable. I apologize, I had written a response to you but it seems it was never sent somehow. I usually wait for Bevy to actually release to upgrade 🎆 Hanabi, but this time I'm going to change a bit and merge your change now. The ETA for Bevy 0.11 is tomorrow anyway, so getting a bit ahead to avoid some crunch later. I might still wait for a package release on crates.io that bevy_inspector_egui gets upgraded, which generally happen in the next 48h after a release, just to avoid having to do 2 releases back to back (without and with the inspector).

@djeedai djeedai marked this pull request as draft July 8, 2023 13:12
@djeedai djeedai marked this pull request as ready for review July 8, 2023 13:12
@djeedai
Copy link
Owner

djeedai commented Jul 8, 2023

Sorry there was a bug with GitHub, it didn't trigger CI, so switched again to Draft and back. Seems that worked.

Copy link
Owner

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a bug in plugin.rs, and all rendering is pink. Working on it...

@djeedai djeedai merged commit ad2dc95 into djeedai:main Jul 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - breaking change A breaking API or behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants