-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orderbase #6
base: master
Are you sure you want to change the base?
Orderbase #6
Conversation
@@ -864,7 +864,7 @@ void CMainFrame::test_waiting(const std::wstring& processName, unsigned processI | |||
{ | |||
EnQueue([this, processName, processId]() | |||
{ | |||
if (this->MessageBox( | |||
if (m_devEnv.AttachDebugger(processId) || this->MessageBox( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djeedjay
This is where the "auto-attach" is integrated: right before the old "Attach debugger ..." dialog is shown.
It still is shown if the auto-attach was unsuccessful.
BoostTestUi/DevEnv.cpp
Outdated
pRot->GetObject(pMoniker, &pObj); | ||
pMoniker.Release(); | ||
|
||
DTEPtr pDte = CComQIPtr<EnvDTE::_DTE>(pObj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a Visual Studio is running and does still implement the rather old interface, this should yield a valid interface pointer for one of the objects in the running object table.
Hi Marvin,
Thank you for your additions to BoostTestUI. I merged your changes in the BoostTestUI 1.1.2 release which is now on the website. The auto debugger atttach feature is very nice!
Regards,
Gert-Jan
… On 15 Jun 2017, at 17:53, Marvin Sielenkemper ***@***.***> wrote:
@sielenk commented on this pull request.
In BoostTestUi/MainFrm.cpp <#6 (comment)>:
> @@ -864,7 +864,7 @@ void CMainFrame::test_waiting(const std::wstring& processName, unsigned processI
{
EnQueue([this, processName, processId]()
{
- if (this->MessageBox(
+ if (m_devEnv.AttachDebugger(processId) || this->MessageBox(
@djeedjay <https://github.com/djeedjay>
This is where the "auto-attach" is integrated: right before the old "Attach debugger ..." dialog is shown.
It still is shown if the auto-attach was unsuccessful.
In BoostTestUi/DevEnv.cpp <#6 (comment)>:
> + CComPtr<IRunningObjectTable> pRot;
+ CComPtr<IEnumMoniker> pEnumMoniker;
+ CComPtr<IMoniker> pMoniker;
+
+ HRESULT hr = GetRunningObjectTable(0, &pRot);
+ if (SUCCEEDED(hr) && pRot)
+ hr = pRot->EnumRunning(&pEnumMoniker);
+
+ if (SUCCEEDED(hr) && pEnumMoniker)
+ while (pEnumMoniker->Next(1, &pMoniker, nullptr) == S_OK)
+ {
+ CComPtr<IUnknown> pObj;
+ pRot->GetObject(pMoniker, &pObj);
+ pMoniker.Release();
+
+ DTEPtr pDte = CComQIPtr<EnvDTE::_DTE>(pObj);
If a Visual Studio is running and does still implement the rather old interface, this should yield a valid interface pointer for one of the objects in the running object table.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#6 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACz1XBjV6mbw_L3nJpMo1wF1B0Go1dPGks5sEVNhgaJpZM4JMawu>.
|
Hi Gert-Jan,
I took the liberty to update your nice test runner to better suit my daily testing needs by adding an "auto attach" feature and a Visual Studio instance selector. To ease the build, I have added the necessary dependencies as NuGet references.
Feel free to pick some of my changes to incorporate them into your main line.
Best regards,
Marvin