This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
FUSETOOLS2-2304: Improve TSLint/ESLint configuration #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pospisilf
force-pushed
the
FUSETOOLS2-2304
branch
from
b8dd265 to
e1c634c
Compare
pospisilf
force-pushed
the
FUSETOOLS2-2304
branch
from
e33b85f to
8047a78
Compare
pospisilf
changed the title
pospisilf
commented
Apr 29, 2024
| @@ -1,5 +1,6 @@ | |||
| import { InputBox, QuickOpenBox, QuickPickItem } from "vscode-extension-tester"; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
There was a problem hiding this comment.
this is not used here but it's interface so there's possibility that some of projects is using this so i guess we should keep this
pospisilf
commented
Apr 29, 2024
| @@ -1,5 +1,6 @@ | |||
| import { error } from "vscode-extension-tester"; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/ban-types | |||
There was a problem hiding this comment.
I am not sure if I can change this to match requirement because I don't correctly understand the background of this file. Can you take a peak please @djelinek?
djelinek
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.