Fix all current validation errors #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as WIP as there's some unresolved testing issues here - for some reason travis is failing this test where it succeeds for me locally. "it works on my machine" :-) |
nward
force-pushed
the
validation_fixes
branch
2 times, most recently
from
b0b574d
to
6a45fed
Compare
nward
changed the title
nward
force-pushed
the
validation_fixes
branch
2 times, most recently
from
9d4f9b9
to
dab9e3a
Compare
Only capture the exec for `radiusd -v`, as facter etc. runs `uname -s` and whatever else. Mock Facter.value for things in os_facts, so we return the value from os_facts rather than the actual value from the system running the tests.
…ol cache size in to puppet, rather than in ERB
nward
changed the title
|
@djjudas21 this should be ready to go, I believe. I've rebased this on master from earlier today, and fixed the earlier issues with the freeradius_version fact rspec - it turns out if you have a fact which calls Facter.value for something, it runs whatever commands it needs, rather than using whatever comes from I think there are probably more modern ways to handle this - using |
|
Woo, the checks passed for the first time in years! Great work, thanks very much. I'm happy to merge this 😄 |
djjudas21
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all outstanding
pdk validateerrors, so now all pdk tests etc. pass.There are no functionality changes here, only test + code style.